Hi Junio, On Thu, 1 Dec 2022, Junio C Hamano wrote: > Paul Smith <psmith@xxxxxxx> writes: > > > On Wed, 2022-11-30 at 09:23 +0100, Ævar Arnfjörð Bjarmason wrote: > >> Since GNU make 4.4 the semantics of the $(MAKEFLAGS) variable has > >> changed in a backward-incompatible way, as its "NEWS" file notes: > > > > Hrm. I did try to look through the other makefiles to find similar > > constructs and get them all, but apparently my grep fu was > > insufficient. Bother. > > > > Thanks. > > Thanks, both. Will queue. I noticed that this patch also touches Git GUI, a change which technically should have come in via https://github.com/prati0100/git-gui, not directly via git/git. So let's make Pratyush [Cc:ed] aware of this change. We probably want to avoid applying Git GUI changes directly to git/git in the future. In the meantime, because I know that Pratyush is busy, I opened https://github.com/prati0100/git-gui/pull/83 with a (partial) backport of this patch. The following command demonstrates that this change is the only divergence that would need backporting into Git GUI (the first SHA is the current tip of git/git's `main` and the second SHA is the latest git-gui tip that was merged into git/git): git diff 2e71cbbddd6:git-gui df4f9e28f64: For the record, there is one change in git-gui's main branch that has not yet made it into git/git [*1*], but it merely appends a full stop character to the end of a sentence in the `README.md` file, therefore there is probably no urgency in pulling git-gui into git any time soon. That typo fix waited over a year to make it into git/git, it can easily wait some more. Ciao, Johannes Footnote *1*: https://github.com/prati0100/git-gui/commit/8cf36407cab
