Am 30.11.2022 um 20:17 schrieb Ævar Arnfjörð Bjarmason:
--- a/builtin/pull.c +++ b/builtin/pull.c @@ -256,7 +256,7 @@ static struct option pull_options[] = { /** * Pushes "-q" or "-v" switches into arr to match the opt_verbosity level. */ -static void argv_push_verbosity(struct strvec *arr) +static void argv_push_verbosity(struct strvec *arr, int include_v) { int verbosity;It looks like you're getting somewhere with this, but you never use this "include_v", so the bug is still there. We just have the scaffolding now. Did you forget to add that part to this commit?
Opps, seems so.
In any case, that serves as a comment on the other thing this patch really needs: tests, please add some.
I don't know how to add tests and don't have a fully fledged build environment for git here.
-- Best regards, Sven Strickroth PGP key id F5A9D4C4 @ any key-server
