On 11/25/22 3:05 AM, Ævar Arnfjörð Bjarmason wrote:
On Fri, Nov 25 2022, Junio C Hamano wrote:
Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
Since 81071626ba1 (trace2: add global counter mechanism, 2022-10-24)
these tests have been failing when git is compiled with NO_PTHREADS=Y,
which is always the case e.g. if 'uname -s' is "NONSTOP_KERNEL".
Reported-by: Randall S. Becker <randall.becker@xxxxxxxxxxxx>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>
---
t/t0211-trace2-perf.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Makes sense, to sweep the immediate breakage under prerequisite.
This change LGTM. The test-tool will report an error trying to
create the requested threads, so there will not be any per-thread
output for the grep to match.
But why would a global counter need threading? I know that the
counters can optionally report per-thread stats, but that is
optional and it would still be useful if we can count events in a
single-threaded program, no?
Timers & counters are accumulated in per-thread local storage.
This allows them to work in a lock-free manner.
Timer/Counter usage by a single-threaded program just accumulates
data in the thread local storage of the "main" thread so that the
code is the same in all cases.
Global timers and counters are accumulated from per-thread ones during
thread-exit. (See calls to `tr2_update_final_timers()` and
`tr2_update_final_counters()` in `trace2_thread_exit_fl()`.)
This is the only step that requires a lock.
There are also calls to those two routines in `tr2main_atexit_handler()`
to accumulate any timer/counter usage in the main thread into the
globals.
The net-net of all of this is that the global (aka final) values
of the timers and counters are always safely computed (and in the
same way) regardless of whether threads were used at any point
during the life of the process. That is, if "main" was the only
thread, the global/final values are just the values from the main
thread.
That was my thought as well, but these tests are specifically testing
how it interacts with threading. The counter mechanism works in general
without threading.
The test descriptions don't help, and should really say that they're to
do with threading in particular, but I wanted to keep this as small as
possible for rc[12] and the final, so I didn't fix that while-at-it.
There is large comment block above `have_timer_event()` and
`have_counter_event()` in t0211 that explained the purpose of the
test1 and test2 tests for each. Would it help if that text were moved
down before each of the individual tests rather than where it is now?
Thanks
Jeff
