On Mon, Nov 28, 2022 at 8:03 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > I think getting rid of the tempfile isn't worth it, or worth worrying > about, what I was pointing out is that the implementation as it stands > works notably differently than if you invoked M-x grep itself. > > I.e. it doesn't do highlighting, and (I didn't note this before) if it > takes a while we'll "hang", if we had emacs itself invoke the "git grep" > we'd stream out grep results as they came in. In PATCH v8, we stopped imitating the grep function and changed it to call the grep function. About the first problem, I still don't understand what you mean by highlighting problem. On my environment, the "*grep*" buffer is colored (i.e. filnemame:line_number part on each line is colored). About the second problem, If the "hang" is until writing to tempfile is completed, it is unavoidable as long as tempfile is used. If the "hang" is no response from Emacs when "cat tempfile" takes a long time, we can reduce the duration by detecting a change in (point-max) and exiting the loop. -- Yoichi NAKAYAMA
