On Mon, Nov 28, 2022 at 9:23 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > I think this approach goes against the effort to implicitly stop relying > on templates. See 3d3874d537a (Merge branch 'ab/test-without-templates', > 2022-07-18) for commits related to that. As I said in the cover letter, it was the conflict of ".git/info" with our internal reference transactions that drew my attention to this test case. This is because our builtin reference-transaction hook which will automatically create a ".git/info" directory to create some files inside, such as ".git/info/checksum", I have to change "mkdir .git/info" to "mkdir -p .git/info" one by one. And I found in this test case, there is a wrong template dir. > I think better thing to do here is to squash this in: > > diff --git a/t/t1301-shared-repo.sh b/t/t1301-shared-repo.sh > index 0b3722aa149..b7222b7bc07 100755 > --- a/t/t1301-shared-repo.sh > +++ b/t/t1301-shared-repo.sh > @@ -8,6 +8,7 @@ test_description='Test shared repository initialization' > GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main > export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > > +TEST_CREATE_REPO_NO_TEMPLATE=1 > . ./test-lib.sh Will use this implementation instead. Thanks. -- Jiang Xin
