On Sun, Nov 27 2022, Junio C Hamano wrote: > Kyle Meyer <kyle@xxxxxxxxxx> writes: > >> Here's a patch handling the -v case. I don't plan on working on a more >> complete fix for the other cases (as I mentioned before, I don't use >> send-email to drive format-patch), but in my opinion the -v fix by >> itself is still valuable. > > Yup, I think it is a good place to stop for the first patch. Other > people can add more when they discover the need, and anything more > complex [*] is probably not worth the effort, I would think. > > Side note: [*] we could imagine running "git format-patch -h" > (or a new variant of it), parse its output and populate the > %options dynamically, for example. > > Will queue. Thanks. This is just a comment on the #leftoverbits: I've looked at this option parsing in "git-send-email" before, and IMO the right long-term fix is to split out the *.perl code into a "git send-email--helper", and do the option parsing in C using our parse_options(). Some of it will be a bit of a hassle, but it should be much easier after 8de2e2e41b2 (Merge branch 'ab/send-email-optim', 2021-07-22) (and the subsquent regression fix).
