On Mon, Nov 28, 2022 at 12:19 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > So I am not sure how this patch can be an improvement. > > If you wrapped the setting of $x, $y, $u and the config into a > helper shell function, e.g. > > prepare_perm_test_variables () { > u=$1 > x=... > y=... > u=... > git config core.sharedrepository "$u" > } I tried, but found the first test case passed, but the other test case in the for loop failed. This is because the variable u is changed twice after prepare_perm_test_variables has been called twice. So, will drop this patch 3/4. -- Jiang Xin