Hi, On Thu, 24 Nov 2022, Johannes Schindelin wrote: > To build even more confidence in the patch series, I will now start a full > run (which will take *a lot* of build minutes, unfortunately). And it passed: https://github.com/dscho/git/actions/runs/3539451056 I also had a look at the range-diff between v1 and v2: -- snip -- 1: ef80c39de1e5 ! 1: 6d4607a4ee46 github-actions: run gcc-8 on ubuntu-20.04 image @@ Commit message ubuntu) ;; + In this way, we can change the "ubuntu-latest" runner image to any + version such as "ubuntu-22.04" to test CI behavior in advance. + Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx> 2: 1d0903c8b2f9 ! 2: eba96648368a ci: upgrade version of p4 @@ Metadata Author: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx> ## Commit message ## - ci: upgrade version of p4 + ci: upgrade version of p4 to 21.2 There would be a segmentation fault when running p4 v16.2 on ubuntu 22.04 which is the latest version of ubuntu runner image for github - actions. Upgrade p4 from version 16.2 to 19.2 will fix this issue. + actions. - Also add some instructions to show errors of command "p4 -V", so we can - see why the output doesn't match. + By checking each version from [1], p4d version 21.1 and above can work + properly on ubuntu 22.04. But version 22.x will break some p4 test + cases. So p4 version 21.x is exactly the version we can use. + + In addition to upgrade p4 from version 16.2 to 21.2, also add some + instructions to show errors of command "p4 -V", so we can see why the + command output doesn't match. + + [1]: https://cdist2.perforce.com/perforce/ Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx> @@ ci/lib.sh: ubuntu) # image. # Keep that in mind when you encounter a broken OS X build! - export LINUX_P4_VERSION="16.2" -+ export LINUX_P4_VERSION="19.2" ++ export LINUX_P4_VERSION="21.2" export LINUX_GIT_LFS_VERSION="1.5.2" P4_PATH="$HOME/custom/p4" -: ------------ > 3: 8e432f13bef8 ci: install python on ubuntu -- snap -- The changes look good! One alternative I considered about 8e432f13bef8 (ci: install python on ubuntu, 2022-11-24) was to drop testing Python v2.x (it's years past end of life after all, see https://endoflife.date/python). However, as we see frequently demonstrated on the Git mailing list: losing focus, trying to force patch series to address more than a single concern, gets us nowhere, and not even fast. So I agree that the best idea in this patch series is the stop-gap solution to install `python2` on `ubuntu-22.04`, and deal with deprecating Python v2.x support separately, later, or never, whichever comes first ;-) With this, here goes my (probably final, because I think this patch series is ready): Reviewed-by: Johannes Schindelin <johannes.schindelin@xxxxxx> Thank you so much for working on this, it was a thoroughly enjoyable experience for me! Ciao, Dscho
