Hi, On Wed, 23 Nov 2022, Jiang Xin wrote: > From: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx> > > There would be a segmentation fault when running p4 v16.2 on ubuntu > 22.04 which is the latest version of ubuntu runner image for github > actions. Upgrade p4 from version 16.2 to 19.2 will fix this issue. I was about to embark on a debugging session when I had the splendid idea to look at the Git mailing list archives to see whether anybody else had encountered that particular problem. However, when I pushed a branch with this fix, it still segfaulted even when downloading version 19.2 (link: https://github.com/dscho/git/actions/runs/3538788474/jobs/5939977231#step:3:387): + wget --quiet https://cdist2.perforce.com/perforce/r19.2/bin.linux26x86_64/p4d + wget --quiet https://cdist2.perforce.com/perforce/r19.2/bin.linux26x86_64/p4 + [...] + echo 'Perforce Server Version' Perforce Server Version + p4d -V + grep Rev. + echo 'p4d: bad version' p4d: bad version + p4d -V ci/install-dependencies.sh: line 91: 3051 Segmentation fault (core dumped) p4d -V I guess I'll embark on that debugging session after all ;-) > Also add some instructions to show errors of command "p4 -V", so we can > see why the output doesn't match. This is an excellent addition. If I read the logs correctly, this change adds the error message "Segmentation fault" to the output, which is really helpful. Thank you for working on this! Dscho > > Signed-off-by: Jiang Xin <zhiyou.jx@xxxxxxxxxxxxxxx> > --- > ci/install-dependencies.sh | 4 ++-- > ci/lib.sh | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index f639263a62..291e49bdde 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -83,9 +83,9 @@ esac > if type p4d >/dev/null 2>&1 && type p4 >/dev/null 2>&1 > then > echo "$(tput setaf 6)Perforce Server Version$(tput sgr0)" > - p4d -V | grep Rev. > + p4d -V | grep Rev. || { echo >&2 "p4d: bad version"; p4d -V; exit 1; } > echo "$(tput setaf 6)Perforce Client Version$(tput sgr0)" > - p4 -V | grep Rev. > + p4 -V | grep Rev. || { echo >&2 "p4: bad version"; p4 -V; exit 1; } > else > echo >&2 "WARNING: perforce wasn't installed, see above for clues why" > fi > diff --git a/ci/lib.sh b/ci/lib.sh > index 0c0767d354..8474b0f249 100755 > --- a/ci/lib.sh > +++ b/ci/lib.sh > @@ -246,7 +246,7 @@ ubuntu) > # were recorded in the Homebrew database upon creating the OS X > # image. > # Keep that in mind when you encounter a broken OS X build! > - export LINUX_P4_VERSION="16.2" > + export LINUX_P4_VERSION="19.2" > export LINUX_GIT_LFS_VERSION="1.5.2" > > P4_PATH="$HOME/custom/p4" > -- > 2.39.0.rc0 > >
