On Tue, Nov 22, 2022 at 11:01:30AM -0800, Glen Choo wrote: > Junio C Hamano <gitster@xxxxxxxxx> writes: > > > * gc/resolve-alternate-symlinks (2022-11-22) 1 commit > > - object-file: use real paths when adding alternates > > > > Resolve symbolic links when processing the locations of alternate > > object stores, since failing to do so can lead to confusing and buggy > > behavior. > > > > Will merge to 'next'. > > source: <pull.1382.v2.git.git.1669074557348.gitgitgadget@xxxxxxxxx> > > I plan to do another reroll based off Ævar's feedback (thanks!), let's > hold off on merging until then? > > Separately, I'd also prefer to hear from Peff regarding my reading of > 37a95862c6 (alternates: re-allow relative paths from environment, > 2016-11-07) and whether we want to continue 'supporting' broken paths in > the environment. I doubt it, but since he initially suggested it in his > fixup patch [1], his opinon would be reassuring :) I just left a review there. I agree with your approach, but I think there are a few small bits that will require a re-roll. -Peff
