ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18))

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Taylor Blau <me@xxxxxxxxxxxx> writes:

> * ab/submodule-no-abspath (2022-11-09) 1 commit
>   (merged to 'next' on 2022-11-18 at 34d0accc7b)
>  + submodule--helper absorbgitdirs: no abspaths in "Migrating git..."
>  (this branch is used by ab/remove--super-prefix.)
>
>  Remove an absolute path in the "Migrating git directory" message.
>
>  Will merge to 'master'.
>  source: <patch-1.1-34b54fdd9bb-20221109T020347Z-avarab@xxxxxxxxx>
>

(Sorry, I should have spoken up before this got merged to 'next'.)

I have some reservations about this that I mentioned in [1], namely:

- Does this work correctly when using a worktree?
- If "absorbgitdirs" becomes consistent with other "git submodule"
  subcommands and prints relative paths to submodules, then this
  produces the wrong result.

We probably won't see any complaints about this for a while, since
submodules + worktrees are an uncommon combination, but I expect that
we'll have to revert this at some point.

[1] https://lore.kernel.org/git/kl6lmt8qv9gc.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux