Re: [PATCH] config: introduce an Operating System-specific `includeIf` condition

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Phillip & Ævar,

[Ævar, in your mail, which I suggest could have used some editing for
spelling and brevity, I found only the concern about `uname -s`
relevant, and since Phillip's suggestion is more actionable than the
somewhat diffuse excurse about something to do with something in a
StackOverflow thread, I will only reply here.]

On Mon, 21 Nov 2022, Phillip Wood wrote:

> On 21/11/2022 13:51, Ævar Arnfjörð Bjarmason wrote:
> >
> > On Mon, Nov 21 2022, Johannes Schindelin via GitGitGadget wrote:
> >
> > [...]
> > > +`os`::
> > > +	The data that follows this keyword is taken as the name of an
> > > +	Operating System; If it matches the output of `uname -s`, the
>
> Maybe add e.g. "Windows or Linux" after Operating System?

Excellent idea. I'll also drop mentioning `uname -s` because it assumes more
about the users' setup than can be assumed.

I also replaced a space character in the added test case that was doubled
by mistake with a single one.

Ciao,
Dscho

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux