> > Also, on macOS, I need to set EDITOR (or GIT_EDITOR or VISUAL) to the > > full path of emacsclient, but the regex used here is too tight to > > recognize that. Perhaps loosening it to just 'emacsclient' would be a > > good idea (as it seems unlikely to falsely match any other editor)? > > It is a good idea. Thanks! I found we can support both emacs and emacsclient by using --eval option instead of -e option. I'll deal with it. On Sun, Nov 20, 2022 at 8:59 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Sat, Nov 19, 2022 at 6:44 PM Yoichi Nakayama > <yoichi.nakayama@xxxxxxxxx> wrote: > > On Sun, Nov 20, 2022 at 12:53 AM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > > Would it make sense to expand this to support the VISUAL and EDITOR > > > environment variables too? For instance, since I want to use Emacs for > > > all my editing needs, I have EDITOR set to reference emacsclient. So, > > > if GIT_EDITOR is unset, then check VISUAL, and if that is unset, check > > > EDITOR. > > > > "git var GIT_EDITOR" does respect VISUAL and EDITOR environment variables. > > See git-var(1) reference manual. > > Excellent. > > > > Also, on macOS, I need to set EDITOR (or GIT_EDITOR or VISUAL) to the > > > full path of emacsclient, but the regex used here is too tight to > > > recognize that. Perhaps loosening it to just 'emacsclient' would be a > > > good idea (as it seems unlikely to falsely match any other editor)? > > > > It is a good idea. Thanks! > > Thanks. -- Yoichi NAKAYAMA
