On Fri, Nov 18, 2022 at 08:27:25PM +0100, Ævar Arnfjörð Bjarmason wrote: > > On Fri, Nov 18 2022, Taylor Blau wrote: > > > On Fri, Nov 18, 2022 at 12:31:06PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> Follow-up the preceding commit and change > >> "USE_THE_INDEX_COMPATIBILITY_MACROS" to the more narrow > >> "USE_THE_INDEX_VARIABLE" in cases where we still use "the_index". > >> > >> Then remove "USE_THE_INDEX_VARIABLE" entirely in the few cases where > >> we don't require any compatibility macros or variables anymore. > > > > Could this get squashed into the previous commit? IOW, is there any > > reason to keep them separate? > > I figured it would be easier to review if I split out the changes that > are coccinelle-created v.s. the ones I made manually. > > But I don't have a preference at all, whatever you think is easier. I think the 11-patch structure makes most sense to me (basically what you have, with the last couple squashed together). Thanks, Taylor
