Le dimanche 14 octobre 2007, Johannes Schindelin a écrit :
> Hi,
>
> On Sun, 14 Oct 2007, Christian Couder wrote:
> > -bisect_bad() {
> > +bisect_state() {
> > bisect_autostart
> > - case "$#" in
> > - 0)
> > - rev=$(git rev-parse --verify HEAD) ;;
> > - 1)
> > - rev=$(git rev-parse --verify "$1^{commit}") ;;
> > + state=$1
> > + case "$#,$state" in
> > + 0,*)
> > + die "Please call 'bisect_state' with at least one argument." ;;
> > + 1,bad|1,good|1,dunno)
> > + rev=$(git rev-parse --verify HEAD) ||
> > + die "Bad rev input: HEAD"
> > + bisect_write "$state" "$rev" ;;
> > + 2,bad)
> > + rev=$(git rev-parse --verify "$2^{commit}") ||
> > + die "Bad rev input: $2"
> > + bisect_write "$state" "$rev" ;;
>
> Really? As far as I see, "2,bad" is an error in the current bisect.
But the new "bisect_state" takes one more argument, because the first one
must be "good" "bad" or "dunno".
So when there is only one argument HEAD is used, and when there are 2
arguments, $2 is used as the good|bad|dunno rev.
> > @@ -404,17 +390,15 @@ bisect_run () {
> > exit $res
> > fi
> >
> > - # Use "bisect_good" or "bisect_bad"
> > - # depending on run success or failure.
> > + # Find current state depending on run success or failure.
> > if [ $res -gt 0 ]; then
> > - next_bisect='bisect_bad'
> > + state='bad'
> > else
> > - next_bisect='bisect_good'
> > + state='good'
> > fi
>
> Maybe it is time to have a special exit status for "dunno"? But this is
> not something to fix in your patch, just an idea for a future patch.
Yes, I will think about it.
Thanks,
Christian.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
