Jeff King <peff@xxxxxxxx> writes: > On Thu, Nov 17, 2022 at 08:41:44PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> This probably isn't worth it, but I wondered if this wouldn't be easier >> if we pulled that memory management into the caller [...] > [......] But crossing a function boundary to me introduces way too many > questions in somebody reading the code (like "is pathbuf supposed to > have something in it?") to make it worth doing here. Thanks, both :) I think the loss of readability is enough for me to hold off on this suggestion, but I don't mind reviewing cleanup patches on top of this.
