On Thu, Nov 17, 2022 at 10:03:06AM -0500, Jeff King wrote: > On Thu, Nov 17, 2022 at 10:19:33PM +0800, Teng Long wrote: > > > > I doubt this buys us much in practice. After patch 2, looking for extra > > > bitmaps is much cheaper. It's one open() call per pack (which will > > > return ENOENT normally) looking for a bitmap. And while it's only 2 > > > lines of code, it does increase coupling of assumptions between the two > > > functions. So maybe not worth doing. I dunno. > > > > I agree and I think it's reasonable. > > > > So If I bring it into the patch how about the commit message: > > [...] > > Both the commit messages you proposed look accurate to me. Yep, ditto. Teng -- would you mind sending them as a short series to the list so that I can pick them up? Otherwise, I can do it if you don't have time or interest. Thanks, Taylor
