Re: [PATCH] builtin/gc.c: fix use-after-free in maintenance_unregister()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/15/22 2:54 PM, Taylor Blau wrote:
> On Tue, Nov 15, 2022 at 08:41:44PM +0100, Ævar Arnfjörð Bjarmason wrote:
>>> @@ -1543,6 +1543,7 @@ static int maintenance_unregister(int argc, const char **argv, const char *prefi
>>>  	int found = 0;
>>>  	struct string_list_item *item;
>>>  	const struct string_list *list;
>>> +	struct config_set cs = { { 0 } };
>>
>> Just "{ 0 }" here instead? I see it may have been copied from some older
>> pre-image though, and they'll do the same in either case, so it's not
>> important...
> 
> Copying from other zero-initializations of `struct config_set`:
> 
>     $ git grep -oh 'struct config_set.*= {.*' | sort | uniq -c
>           3 struct config_set cs = { { 0 } };

Yes, without the double braces the compiler will complain on
macOS, I believe.

Thanks,
-Stolee



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux