On Tue, Nov 15, 2022 at 06:20:05PM +0000, Johannes Schindelin via GitGitGadget wrote: > Let's offer a way to read those patches from pre-prepared MBox files > instead when an argument "mbox:<filename>" is passed instead of a commit > range. Very cool. Thanks for working on this. I don't have time to review the whole parser right now (and I agree that it would be nice to see it hook into the existing stuff in mailinfo.c), but the idea sounds delightful. If it's possible to use the battle-tested parts of mailinfo.c without much effort, I'd be in favor of waiting on that. But in case that it's not, I agree with you that we shouldn't let perfect be the enemy of the good[^1], either. Thanks, Taylor [^1]: Though let's make sure that "good" doesn't have any buffer overruns in it ;-)
