On Wed, Nov 09, 2022 at 09:17:25PM -0500, Taylor Blau wrote: > On Thu, Nov 10, 2022 at 12:55:30AM +0100, Ævar Arnfjörð Bjarmason wrote: > > But we generally just fail some or all of 3..9 pretty fast, and don't > > start taking 20 minutes to run the test, when it took 10s before (or > > whatever). > > OK. I still think that in principle this is indistinguishable from not > running a setup test to completion. > > *But*: I'm willing to treat them differently since instead of > manifesting in an immediate failure later on in the suite, we hang for a > substantial period of time. > > So I'm content to merge this down, but I don't think it's worth > searching out for more of these in the future. Having merged this down to 'next', it looks like there is some CI fallout on the Windows tests, see: https://github.com/ttaylorr/git/actions/runs/3473324797/jobs/5805324776 I am not sure how I might have caught this earlier not having a Windows machine myself. Regardless, let's make sure that it is fixed up before this graduates. Thanks, Taylor
