On Tue, Nov 15, 2022 at 12:07:06PM -0500, Jeff King wrote: > On Tue, Nov 15, 2022 at 10:32:42AM +0100, Ævar Arnfjörð Bjarmason wrote: > > > Since fc304fb52f9 (Merge branch 'dd/git-bisect-builtin' into next, > > 2022-11-14) we've used builtin/bisect.c instead of git-bisect.sh to > > implement the "bisect" command. Let's remove the unused leftover > > script, and the ".gitignore" entry for the "git-bisect--helper", which > > also hasn't been built since fc304fb52f9. > > A small nit, but it's probably not a good idea to refer to merge commits > from 'next'. They may be meaningful now, but they aren't part of the > long-term history, and will get gc'd eventually when Junio rewinds next > after a release. Which will leave this reference useless for people > looking at "git log" a year from now. > > A better reference is probably 73fce29427 (Turn `git bisect` into a full > built-in, 2022-11-10), which will remain stable as it gets merged > eventually into master. Thanks, I updated the reference to point at 73fce29427 while queueing. As an aside, I am a little disappointed by the quality of what has recently been hitting 'next'. There was no chance for me to find the issues with t7610 without a Windows machine, but this should have been caught during testing. Thanks, Taylor
