On Tue, Nov 15, 2022 at 07:28:43AM +0100, Patrick Steinhardt wrote: > On Mon, Nov 14, 2022 at 11:50:11PM -0500, Taylor Blau wrote: > [snip] > > * ps/receive-use-only-advertised (2022-11-11) 7 commits > > - receive-pack: only use visible refs for connectivity check > > - rev-parse: add `--exclude-hidden=` option > > - revision: add new parameter to exclude hidden refs > > - revision: introduce struct to handle exclusions > > - revision: move together exclusion-related functions > > - refs: get rid of global list of hidden refs > > - refs: fix memory leak when parsing hideRefs config > > > > "git receive-pack" used to use all the local refs as the boundary > > for checking connectivity of the data "git push" sent, but now it > > uses only the refs that it advertised to the pusher. In a > > repository with the .hideRefs configuration, this reduces the > > resource needed to perform the check, and also forces the pusher to > > prove they have all objects that are necessary to complete the > > history on top of only the history available to them. > > We have at a later point established that this is not true: the pusher > does not have to prove they have all objects. As the `--not --all` part > in git-rev-list(1) is merely an optimization the semantics aren't > changed at all Thanks; this is Junio's description from when he picked up the topic back in WC #08 from October. I'll need to update before graduating it down. > > Expecting a (final?) reroll. > > I think this is stale, right? There was no further feedback until now, > and in your [1] you say that things look good to you, but that you > intend to wait a few days for further feedback. > > Thanks! Yes, that is indeed stale, thanks for catching. I'm just waiting for a review from somebody that isn't you or me ;-). Thanks, Taylor
