Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 40939b0b18e..e13615eb939 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -131,13 +131,6 @@ static char *get_submodule_displaypath_sp(const char *path, const char *prefix,
> }
> }
>
> -static char *get_submodule_displaypath(const char *path, const char *prefix)
> -{
> - const char *super_prefix = get_super_prefix();
> -
> - return get_submodule_displaypath_sp(path, prefix, super_prefix);
> -}
> -
It feels a bit odd that the function we keep is the one with _sp,
especially since the "original" is gone. FWIW, I wouldn't mind if we
just changed the signature of get_submodule_displaypath() instead of
introducing the _sp helper.
