Hi Taylor, On Sat, 12 Nov 2022, Taylor Blau wrote: > On Sat, Nov 12, 2022 at 10:07:34PM +0000, Johannes Schindelin via GitGitGadget wrote: > > From: Johannes Schindelin <johannes.schindelin@xxxxxx> > > > > It is more performant to run `git diff --no-index` than running the > > `mingw_test_cmp` code with MSYS2's Bash, i.e. the Bash that Git for > > Windows uses. And a lot more readable. > > This makes sense, and motivates the changes below. > > > Note: Earlier attempts at fixing this involved a test helper that avoids > > the overhead of the diff machinery, in favor of implementing a behavior > > that is more in line with what `mingw_test_cmp` does now, but that > > attempt saw a lot of backlash and distractions during review and was > > therefore abandoned. > > But I do not think that this paragraph adds as much as we'd like to the > historical record. It explains why we replace a relatively simple logic with a relatively complex one. > What about the original approach did you have trouble pushing forward? > Perhaps framing that as an alternative approach, along with why it > didn't ultimately get merged would be a more useful recollection of > previous attempts here. > > One thing that the commit message doesn't allude to (that is covered in > the earlier discussion) is why it is important to pass > `--ignore-cr-at-eol`. I think that is worth mentioning here. I elaborated on both in the new commit message. Ciao, Dscho
