Re: [PATCH 2/6] add get_sha1_with_real_ref() returning full name of ref on demand

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Oct 14, 2007, at 7:21 PM, Johannes Schindelin wrote:

Hi,

On Sun, 14 Oct 2007, Steffen Prohaska wrote:

Deep inside get_sha1() the name of the requested ref is matched
according to the rules documented in git-rev-parse. This patch
introduces a function that returns the full name of the matched
ref to the outside.

For example 'master' is typically returned as 'refs/heads/master'.

The new function can be used by "git rev-parse" to print the full
name of the matched ref and can be used by "git send-pack" to expand
a local ref to its full name.

I have not really studies your patch, but from your description it sounds
as if dwim_ref() does what you want.

Without my patch get_sha1_with_mode() calls get_sha1_1() calls get_sha1_basic() calls dwim_ref(). I didn't analyze in detail what the *sha1* functions add
to what dwim_ref() provides.

The patch passes the information from dwim_ref() up the callstack. Maybe this
is not needed and I could directly call dwim_ref(). But I don't know.

	Steffen
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux