On Thu, Nov 10, 2022 at 07:06:00PM +0000, Victoria Dye via GitGitGadget wrote: > Changes since V2 > ================ > > * Cleaned up option handling & provided more informative error messages in > 'test-tool cache-tree'. The changes don't affect any behavior in the > added tests & 'test-tool cache-tree' won't be used outside of > development, but the improvements here will help future readers avoid > propagating error-prone implementations. > * Note that the suggestion to change the "unknown subcommand" error to a > 'usage()' error was not taken, as it would be somewhat cumbersome to > use a formatted string with it. This is in line with other custom > subcommand parsing in Git, such as in 'fsmonitor--daemon.c'. Thanks. The range-diff confirms what you say above. So between that and an affirmative review on the last round, I think we are ready to start merging this one down. Thanks, Taylor
