Re: [PATCH v2 0/9] submodule: tests, cleanup to prepare for built-in

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes:

> On Tue, Nov 08 2022, Glen Choo wrote:
>
>> [...]
>> Thanks! This addresses all of my comments from v1, and I didn't 
>> spot any other issues during a quick 2nd pass.
>>
>>   Reviewed-by: Glen Choo <chooglen@xxxxxxxxxx>
>
> Thanks for the quick review!
>
> One thing I completely forgot in the v2 CL: The 3/9 here is new. Stictly
> speaking we could skip it, but I wanted to be able to mark the new test
> I added as as leak-free, and fixing the only leak it ran into was
> trivial:
> https://lore.kernel.org/git/patch-v2-3.9-a3529d7f9e0-20221108T140501Z-avarab@xxxxxxxxx/
>
> So rather than having another "small leak fix for submodules" topic
> depend on this topic, I think it's OK to just bundle that up with this
> one.

Yes, it looked quite trivial. IMO bundling this was a more efficient use
of time than sending another series.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux