Hi,
On Sun, 14 Oct 2007, Wincent Colaiuta wrote:
> > +sub parse_color {
>
> You could simplify the manual escape sequence construction that you're
> doing here by using Term::ANSIColor like the other patches did. I see
> that git-send-email.perl uses that module too, so I guess depending on
> that module is ok.
Wrong. Depending on that module is not correct, you always have to wrap
it into an "if (<is_color>) {...}".
I use git add -i quite often, and I _never_ use git send-email. My guess
is that I am not alone with that.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
