On 11/2/22 6:09 PM, Matthew John Cheetham via GitGitGadget wrote: > Following from my original RFC submission [0], this submission is considered > ready for full review. This patch series is now based on top of current > master (9c32cfb49c60fa8173b9666db02efe3b45a8522f) that includes my now > separately submitted patches [1] to fix up the other credential helpers' > behaviour. > Updates in v3 > ============= > > * Split final patch that added the test-http-server in to several, easier > to review patches. > > * Updated wording in git-credential.txt to clarify which side of the > credential helper protocol is sending/receiving the new wwwauth and > authtype attributes. You also updated some commit messages based on v2 feedback. Thanks! The commit splitting you did in this version is greatly appreciated. I found this version to be in good shape. It's a solid foundation to build upon (if any future work is necessary). Thanks, -Stolee
