On Thu, Nov 03 2022, Taylor Blau wrote: > * ab/config-multi-and-nonbool (2022-11-02) 9 commits > - for-each-repo: with bad config, don't conflate <path> and <cmd> > - config API: add "string" version of *_value_multi(), fix segfaults > - config API users: test for *_get_value_multi() segfaults > - for-each-repo: error on bad --config > - config API: have *_multi() return an "int" and take a "dest" > - versioncmp.c: refactor config reading next commit > - config tests: add "NULL" tests for *_get_value_multi() > - config tests: cover blind spots in git_die_config() tests > - for-each-repo tests: test bad --config keys > > A mixed bag of config API updates. > > Expecting a reroll. > cf. <221026.86pmeebcj9.gmgdl@xxxxxxxxxxxxxxxxxxx> > source: <cover-v2-0.9-00000000000-20221101T225822Z-avarab@xxxxxxxxx> The "mixed bag" part of this comes from Junio's v1 summary[1], which I think I addressed by narrowing the scope in the v2[2]. Per [3] it looks like you were going to try to find time to take a second look, *gentle poke* :) 1. https://lore.kernel.org/git/xmqqy1szef49.fsf@gitster.g/ 2. https://lore.kernel.org/git/cover-v2-0.9-00000000000-20221101T225822Z-avarab@xxxxxxxxx/ 3. https://lore.kernel.org/git/Y2G+qczur9eLVtk5@nand.local/