Re: [PATCH v2 2/3] revision: add new parameter to specify all visible refs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 03, 2022 at 03:37:32PM +0100, Patrick Steinhardt wrote:

> diff --git a/t/t6021-rev-list-visible-refs.sh b/t/t6021-rev-list-visible-refs.sh
> new file mode 100755
> index 0000000000..9e12384dcf

Oh, I forgot to mention in my earlier response: these tests mostly look
good to me, but it may be worth having a few that cover the namespaces
feature. I _think_ your code is doing the right thing (because it calls
strip_namespace() as appropriate), but I have to admit I am generally
confused about how the namespace feature works in the first place. So
it's probably good to figure out how it is supposed to interact here and
make sure it is covered by tests.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux