On Sunday 14 October 2007 02:57, Johannes Schindelin wrote:
> Hi,
>
> On Sat, 13 Oct 2007, Johannes Sixt wrote:
> > -int finish_connect(pid_t pid)
> > +int finish_connect(struct child_process *conn)
> > {
> > - if (pid == 0)
> > + if (conn == NULL)
> > return 0;
> >
> > - while (waitpid(pid, NULL, 0) < 0) {
> > + while (waitpid(conn->pid, NULL, 0) < 0) {
> > if (errno != EINTR)
> > return -1;
>
> Just for completeness' sake: could you do a free(conn); before return -1;?
I know. But the loop is going away with the next patch, so I didn't bother.
Can you live with that?
-- Hannes
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
