On Tue, Nov 01, 2022 at 11:17:42PM +0100, Ævar Arnfjörð Bjarmason wrote: > >> The tests aren't just asserting the bad behavior, they're also ensuring > >> that it doesn't get worse. 1 warning is ideal, 2-3 is bad, but > >> tolerable, but if we start emitting 500 of these it would be nice to > >> know. > > > > I admit that this kind of argument does not sway me. > > > > Is it likely that we would suddenly start spewing 500 such warnings? If > > we did, are there no other tests that would catch it? And even if *that* > > were the case, would nobody happen to notice it in the meantime either > > during development or when we queue an affected topic onto 'next' for > > wider testing? > > > > I guess the answer is that it's possible that we'd miss such a > > regression in all of those above places, but to me it seems extremely > > unlikely that we'd let such a regression through without noticing. > > Literally 500? Probably not, that was hyperbole to make a point, but > several, low tens? Yeah, I know of at least a couple in-tree off the top > of my head. Still, I find it suspect to assume that a developer working in this area wouldn't notice even a minor regression (say, adding an additional warning). Thanks, Taylor
