On Mon, Oct 31, 2022 at 07:22:48PM -0400, Jeff King wrote: > > diff --git a/t/t5516-fetch-push.sh b/t/t5516-fetch-push.sh > > index 8dd4610a8c2..980c594940b 100755 > > --- a/t/t5516-fetch-push.sh > > +++ b/t/t5516-fetch-push.sh > > @@ -1860,15 +1860,15 @@ test_expect_success LIBCURL 'fetch warns or fails when using username:password' > > > > test_must_fail git -c transfer.credentialsInUrl=warn fetch https://username:password@224.0.0.1 2>err && > > grep "warning: $message" err >warnings && > > - test_line_count = 3 warnings && > > + test_line_count -ge 1 warnings && > > I think this test_line_count (and all the others) is now superfluous; > the exit code of grep will tell us if we found anything. > > I don't mind it too much, though, if we're planning to fix the duplicate > messages, at which point it becomes s/-ge/=/. Yeah, agreed. Let's leave it alone, unless somebody else feels strongly. Thanks, Taylor
