On Mon, Oct 31, 2022 at 1:16 AM Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote: > > On 10/30/2022 2:35 AM, Abhradeep Chakraborty wrote: > > Hello all, > > > > It has been a month since I didn't get involved in any open source > > contributions (including Git). This is due to the fact that I was > > focusing more on mastering theories and also that it was a festive > > month. So, I am now resuming my work. There are many things I have to > > cover (including this patch series). > > But before that I want to ask you a question - As you have noticed > > already, the Roaring library has a lot of styling issues (Moreover it > > is using C11). So Should I fix all these issues? or Should I make a > > new library (using Git's compatibility library "git-compat-util.h") by > > taking CRoaring as a reference? The pros are that it would be easier > > to format the bitmap library specific files and it can use Git > > compatible functions. > > > > I would love to hear your opinions. Thanks :) > > I HAVE OPINIONS! :D > > Mostly, there are two things I'd like for you to keep in mind: > > 1. Using the library as-is is a great way to prototype and dig in on > the performance measurement side. Can you construct or clone enough > interesting repositories to get a feeling of the effect of the > roaring format compared to the EWAH format? If there is no benefit > to switching, then we can save everyone a lot of work by marking > that as an incorrect road. However, if there is sufficient evidence > that it's working well, then we have established a baseline that > the full implementation should match (at least, if not do better). Got it. Yeah, I can do it. Now I am very much clear about how to proceed with it ;-) Thanks for your reply!!
