Hi,
On Sat, 13 Oct 2007, Johannes Sixt wrote:
> status = finish_command(&child_process);
> if (status)
> - error("external filter %s failed %d", cmd, -status);
> + error("external filter %s failed", params->cmd);
Did you mean to remove the status from the output (it should probably read
"(exit status %d)" instead of just "%d", but an exit status can help
identify problems, right?
> - child_process.pid = fork();
> - if (child_process.pid < 0) {
> - error("cannot fork to run external filter %s", cmd);
> - close(pipe_feed[0]);
> - close(pipe_feed[1]);
> - return NULL;
> - }
> - if (!child_process.pid) {
> - close(pipe_feed[0]);
> - exit(filter_buffer(pipe_feed[1], src, *sizep, cmd));
> - }
> - close(pipe_feed[1]);
> + if (start_async(&async))
> + return 0; /* error was already reported */
Please write "return NULL;"
Thanks,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
