On Sun, Oct 30, 2022 at 12:58:13PM +0100, René Scharfe wrote: > > Changes since v1: > > - Do the return value fix earlier; it was only an afterthought before. > > Keep the colon (no "while at it, ..."). > > - Break out the xstrdup(), oid_to_hex_r() and C99 cleanups. > > - Convert tricky string arrays before strvecs because Ævar didn't like > > the opposite order. > > - Extend the example code in tmp-objdir.h so it still only requires > > "cmd". > > Forgot one: > - Fix grammar error in run-command.h added by the series in a comment > that goes away at the end. > > René Thanks, replaced. This round is looking good to me, though let's hear from ÆVar before we start merging this down. Thanks, Taylor
