On Fri, Oct 28, 2022 at 12:26:51AM +0200, Ævar Arnfjörð Bjarmason wrote: > But given the line count of some of the other changes, and > e.g. including the free(), oid_to_hex_r() to oid_to_hex() etc. in later > commits I don't see why we can't just make it use run_command() > directly. > > I.e. I think it makes sense as one commit, but the conversion is easy > enough, easier than looking at the same code again later in the > series... Hmmph. I don't think that it matters much, either way. I was initially confused not having read the whole series, but I see what you're saying now. We see the same part of the diff twice here: the post-image of this hunk to use run_command_v_opt() becomes the pre-image of a hunk in one of the later patches to change it to use run_command() directly. Arguably the two could be combined into a single patch, yes. Though I find the version as written here to be clearer, since it's a straightforward code movement within bisect--helper. Thanks, Taylor
