Re: [PATCH v2 0/3] Makefile: fix issues with bin-wrappers/% rule

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 26, 2022 at 04:42:34PM +0200, Ævar Arnfjörð Bjarmason wrote:

> This simple topic fixes issues with the bin-wrappers/% rules, as seen
> in the range-diff below this never worked properly:
> 
> 	make bin-wrappers/git
> 
> I.e. we'd make the scirpt, but not "git".

Maybe I'm missing something, but the current behavior is what I'd expect
to happen. Sure, bin-wrappers/git depends on "git" at run-time if you
want it to do something useful. But AFAIK it doesn't at build-time. Why
do we want a build-time dependency?  Are we expecting rules to depend on
bin-wrappers/foo but not also on foo? Or people to ask manually for
those targets?

This kind of feels like making git-repack depend on git-pack-objects.
One will call the other at run-time, but there's no reason the builds
have to be together. And if you try to build and run one without
building the other, well...if it hurts, don't do it.

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux