Junio C Hamano <gitster@xxxxxxxxx> writes: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > >> Fix numerous and mostly long-standing segfaults in consumers of >> the *_config_*value_multi() API. As discussed in the preceding commit >> an empty key in the config syntax yields a "NULL" string, which these >> users would give to strcmp() (or similar), resulting in segfaults. > > Sounds like a good idea. > > I would have called them _nonbool(), not _string(), especially > because we are not going to have other variants like _int(), though. Actually, I take it back. Instead of introducing _string(), how about introducing _bool() and convert those minority callers that do want to see boolean values to use the new one, while rejecting NULLs for everybody else that calls the traditional "get_value" family of functions? That would "optimize" for the majority of simpler users, wouldn't it?
