On Sun, Oct 23, 2022 at 08:47:35AM +0200, René Scharfe wrote: > absorb_git_dir_into_superproject() uses a strbuf and strvec_pushl() to > build and add the --super-prefix option and its argument. Use a single > strvec_pushf() call to add the stuck form instead, which reduces the > code size and avoids a strbuf allocation and release. The same is > already done in submodule_reset_index() and submodule_move_head(). Nice. Unlike some of the earlier discussion around child_process args, this one seems like a very clear win. -Peff
