On Sat, Oct 13, 2007 at 04:45:41PM +0200, Wincent Colaiuta wrote: > - as Johannes pointed out, "clear" and "reset" are not used consistently > even though the Term::ANSIColor documentation says that they're the same, so > settled on "clear"; although in any case, the changes to the > print_ansi_color function mean that it is now the only site where clearing > takes place Please use "reset", as that is the term used by the C color code. > - changed the regex as suggested by Johannes, and a couple of others that > are used when splitting hunks I believe there are other places where the diff output is parsed, and the colors will mess that up, too (e.g., split_hunk). All of those regexes need to be changed, too. I am a bit concerned that we are putting intimate knowledge of the colorization scheme here. As much as it pains me to have two diff colorizers, I wonder if that would be a better solution than having a diff colorizer, and a colorized diff parser. -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
