Jeff King <peff@xxxxxxxx> writes: > On Fri, Oct 21, 2022 at 01:45:13PM +0000, Phillip Wood via GitGitGadget wrote: > >> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> >> >> If the input to strtoimax() or strtoumax() does not contain any digits >> then they return zero and set `end` to point to the start of the input >> string. git_parse_[un]signed() do not check `end` and so fail to return >> an error and instead return a value of zero if the input string is a >> valid units factor without any digits (e.g "k"). > > This one is easier to test than the last. Just: > > git config --int --default='m' some.key > > works. And even playing devil's advocate, I can't think of a case where > anybody would rely on the current behavior. Hmph, but --default=" m" would not be caught with the patch with the same error, but is still a valid way to say zero mega unit. Personally I do not see if this one is worth worrying about at all, even though the fixes in 1/3 and 3/3 may be more worthwhile. THanks.
