On Thu, Oct 20, 2022 at 10:43:07AM -0700, Junio C Hamano wrote: > Torsten Bögershausen <tboegi@xxxxxx> writes: > > > What more is needed ? > > To fix all other bugs/issues/limitations in diff.c ? > > If yes, they need to go in separate commits anyway, or do I miss > > something ? > > At least leave some NEEDSWORK comment in the code that is known to > need more work, to remind others that the fix in the area of the > code is not done, perhaps. Otherwise, much of the effort in the > review gets lost. > > I offhand recall at least two (please go back to the original thread > to find the details of them). One that measures the width of > long/path/name in bytes to determine where to start chomping in the > diffstat filename (because it still mixes display columns and > bytes), and the other one that measures the width of leading graph > segment in bytes without ignoring the ANSI color sequence, which > should be using utf8_strnwidth() but is using strlen(). > > https://lore.kernel.org/git/xmqqpmfx52qj.fsf@gitster.g/ > > Thanks. Good, good, good. For the moment I don't have any spare time to spend on Git. All your comments are noted, and I hope to get time to address them later. If you kick out the branch from seen and the whats cooking list, that would be fine with me.
