Hi Ævar, On Fri, 21 Oct 2022, Ævar Arnfjörð Bjarmason wrote: > On Tue, Oct 18 2022, Johannes Schindelin wrote: > > [For context: > https://lore.kernel.org/git/on2q3qos-sr0n-0p8p-606p-5pq39n46qq4q@xxxxxx/ > is upthread of here, but spinning this off into another thread] > > >> Re my earlier feedback, I came up with this as an alternative, which > >> nicely allows us to have "cmake" and "make" play together, you can even > >> run them concurrently!: > >> > >> https://github.com/avar/git/commit/30f2265fd07aee97ea66f6e84a824d85d241e245 > > > > This approach _still_ modifies the `test-lib.sh`, which is the entire > > reason for the patch under review. > > > > I hope you find an elegant, user-friendly alternative that leaves > > `test-lib.sh` unmodified even when building via CMake. I would gladly take > > that and drop my `GIT-BUILD-DIR` patch. > > You did ask for it :) Well, I asked for something elegant, which in my mind is always something succinct. A 9-patch series is not succinct ;-) Sadly, I am already struggling to whittle down my work queue as it is, and am quite deer-in-the-headlights about having to find the time to review anything longer than a short patch in addition to what is already in the queue :-( Hopefully next week. Thank you for working on this, Johannes
