Re: [PATCH v2 3/6] shortlog: extract `--group` fragment for translation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 20, 2022 at 11:11:35PM -0400, Taylor Blau wrote:

> The subsequent commit will add another unhandled case in
> `read_from_stdin()` which will want to use the same message as with
> `--group=trailer`.
> 
> Extract the "--group=trailer" part from this message so the same
> translation key can be used for both cases.

Continuing my thoughts from the previous patch, this one actually makes
more sense to me in the order you have it. I.e., making it more generic
ahead of time, instead of afterwards saying "hey, these two messages are
very similar".

I'm not sure what makes me see them differently. It's possible I'm
simply not consistent and you should ignore me. :)

-Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux