On Mon, Oct 10, 2022 at 10:15:32PM -0400, Jeff King wrote: > > > > @@ -439,8 +440,8 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix) > > > > log.file = rev.diffopt.file; > > > > log.date_mode = rev.date_mode; > > > > > > > > - if (!log.groups) > > > > - log.groups = SHORTLOG_GROUP_AUTHOR; > > > > + shortlog_init_group(&log); > > > > + > > > > string_list_sort(&log.trailers); > > > > > > Now that we have a "finish the shortlog init" function, probably this > > > trailer sort should go into it, too. The current caller doesn't need it, > > > but it removes on more gotcha from using the shortlog API. > > > > We'll drop this list by the end of the series, too, so it probably isn't > > worth moving it into shortlog_finish_setup() in the interim. > > Ah, right. Well, see my other comments. :) Seen ;-). Now that this series no longer touches the log.trailers bits, we should move this around. Done locally, will send a reroll shortly or tomorrow. Thanks, Taylor
