Re: [PATCH 7/7] shortlog: implement `--group=trailer` in terms of `--group=<format>`

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 10, 2022 at 09:50:42PM -0400, Jeff King wrote:
> Hmph. So that's _probably_ OK, but I have to wonder if this is going too
> far. The resulting code is not that much shorter, and IMHO is actually a
> little more complicated, because of this hack and the extra util bit.

Thanks for a careful analysis, as always. "Additional complexity" and
"slower" are both usually not worth it in isolation, but it's definitely
difficult to advocate for doing both at the same time ;-).

Let's drop this patch and let the `--group=trailer` bits continue to
benefit from your optimizations.

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux