Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Remove the cmd_sync() wrapper for "git submodule--helper sync" in > favor of dispatching the raw command-line directly to the helper. > > At this point we've already parsed out the optional "--quiet" flag > that we need to support for "git submodule --quiet" (as opposed to > "git submodule <subcommand> --quiet"). For a moment, I thought this was saying that we're dropping support for "git submodule <subcommand> --quiet" in favor of "git submodule --quiet", but that's not true. Both are still supported, albeit in slightly different ways: - The subcommand "--quiet" flag is passed via $@ - The top level "--quiet" flag is parsed when we parse top level flags, which sets quiet=1, and thus passes "--quiet" to submodule--helper. We also `shift` out the "--quiet" so there's no fear of passing "--quiet" twice. Hooray!
