On Thu, Oct 20, 2022 at 12:13 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > So here is my "panda-see-panda-do" attempt. > > ----- >8 --------- >8 --------- >8 --------- >8 --------- >8 ----- > Subject: [PATCH] ci: use DC_SHA1=1 on osx-clang job for CI > > All other jobs were using the default DC_SHA1 (which is a > recommended practice), but the default for macOS jobs being Apple's > common crypt, we didn't catch recent breakage soon enough. "recent breakage" is quite vague and probably won't help future readers understand what this is actually fixing. Possible improvements: (1) a prose description of the breakage; (2) the actual compiler error message; (3) a pointer[1] to the email reporting the problem. One or more of the above improvements to the commit message would help future readers. [1]: https://lore.kernel.org/git/kl6l7d0yyu6r.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx/ > We may want to give similar diversity for Linux jobs so that some of > them build with other implementations of SHA-1, but let's start > small and fill only the immediate need. > > Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx> > --- > diff --git a/ci/lib.sh b/ci/lib.sh > index 1b0cc2b57d..5a115704cb 100755 > --- a/ci/lib.sh > +++ b/ci/lib.sh > @@ -259,6 +259,8 @@ macos-latest) > MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)" > else > MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)" > + MAKEFLAGS="$MAKEFLAGS NO_APPLE_COMMON_CRYPTO=NoThanks" > + MAKEFLAGS="$MAKEFLAGS DC_SHA1=1 NO_OPENSSL=1" > fi > ;; > esac
